Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests fail because of deprecated try macro #4385

Closed
wants to merge 1 commit into from
Closed

Fix tests fail because of deprecated try macro #4385

wants to merge 1 commit into from

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Aug 15, 2019

changelog: none

@ghost
Copy link

ghost commented Aug 15, 2019

This isn't my decision but shouldn't we be removing support for the try! macro completely? Supporting deprecated features should be out of scope, in my opinion.

@flip1995
Copy link
Member

Supporting deprecated features should be out of scope, in my opinion.

Yeah, with try! deprecated, Clippy should also drop support for it.

@matthiaskrgr matthiaskrgr mentioned this pull request Aug 15, 2019
Closed
@flip1995 flip1995 mentioned this pull request Aug 15, 2019
Merged
@flip1995
Copy link
Member

I removed tests with the try! macro in #4388. I think this is the right thing to do here.

@tesuji tesuji closed this Aug 15, 2019
@tesuji tesuji deleted the allow-try-in-test branch August 15, 2019 08:33
bors added a commit that referenced this pull request Aug 15, 2019
@bors
Auto merge of #4388 - flip1995:rustup, r=phansch
3fc4975 
Rustup

Supersedes #4387 and #4385

This removes tests with the `try!` macro in them completely. There is no need for Clippy to support the `try!` macro, since it is deprecated now.

[`StmtKind`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/hir/enum.StmtKind.html) got a new variant [`Semi`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/hir/enum.StmtKind.html#variant.Semi), which Just Works™ with the `author` lint. Nice.

changelog: none
bors added a commit that referenced this pull request Aug 15, 2019
@bors
Auto merge of #4388 - flip1995:rustup, r=phansch
34457fb 
Rustup

Supersedes #4387 and #4385

This removes tests with the `try!` macro in them completely. There is no need for Clippy to support the `try!` macro, since it is deprecated now.

[`StmtKind`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/hir/enum.StmtKind.html) got a new variant [`Semi`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc/hir/enum.StmtKind.html#variant.Semi), which Just Works with the `author` lint. Nice.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tesuji @flip1995