Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate should_assert_eq lint #2156

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Deprecate should_assert_eq lint #2156

merged 1 commit into from
Oct 20, 2017

Conversation

cgm616
Copy link
Contributor

@cgm616 cgm616 commented Oct 20, 2017

This should close #2090.

@cgm616
Copy link
Contributor Author

cgm616 commented Oct 20, 2017

It looks like as least one of the travis checks failed due to nightly changes (on nightly-2017-10-18 it compiles, and the failing code is nowhere near what I messed with).

@oli-obk
Copy link
Contributor

oli-obk commented Oct 20, 2017

I restarted travis

@oli-obk oli-obk merged commit 9293188 into rust-lang:master Oct 20, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Oct 20, 2017

Thanks for taking over the stale PR

@ndmitchell ndmitchell mentioned this pull request Jan 25, 2021
Open
@sylvestre sylvestre mentioned this pull request Mar 23, 2022
Merged
@nicklimmm nicklimmm mentioned this pull request Jan 9, 2024
Closed
@smoelius smoelius mentioned this pull request Sep 2, 2024
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop linting assert!(x == y)
2 participants
@cgm616 @oli-obk