-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split needless_lifetime
'_
suggestions into elidable_lifetime_names
#13960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this lint splitting, I'm just not sure about the category to use for the new lint.
03ada72
to
9d98207
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two documentation nits, but otherwise LGTM :D
(Sorry, for the delay with the review, RL is currently taking more time than before ^^')
And thank you to @samueltardieu for his review! <3
b874f45
to
50cc391
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for addressing my previous comments :D
I've created an FCP
Roses are 'red,
Violets are 'blue,
Those lifetimes are,
needless and elidable,
but still needed,
for the poem flow,
50cc391
to
eba6f78
Compare
eba6f78
to
efcf1f5
Compare
The FCP has concluded (Sorry, for not following up on this earlier 🙈 ) |
Fixes #13514
changelog: Added [
elidable_lifetime_names
] topedantic
(Split off from [needless_lifetime
] for suggestions with'_
)#13960
changelog: Enhancement: [
needless_lifetime
] No longer lints for elidable lifetimes'_
, use [elidable_lifetime_names
] to lint these.#13960