Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split needless_lifetime '_ suggestions into elidable_lifetime_names #13960

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

Alexendoo
Copy link
Member

@Alexendoo Alexendoo commented Jan 7, 2025

Fixes #13514

changelog: Added [elidable_lifetime_names] to pedantic (Split off from [needless_lifetime] for suggestions with '_)
#13960

changelog: Enhancement: [needless_lifetime] No longer lints for elidable lifetimes '_, use [elidable_lifetime_names] to lint these.
#13960

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2025

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 7, 2025
Copy link
Contributor

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this lint splitting, I'm just not sure about the category to use for the new lint.

@Alexendoo Alexendoo force-pushed the split-needless-lifetimes branch 2 times, most recently from 03ada72 to 9d98207 Compare January 19, 2025 17:09
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two documentation nits, but otherwise LGTM :D

(Sorry, for the delay with the review, RL is currently taking more time than before ^^')

And thank you to @samueltardieu for his review! <3

@Alexendoo Alexendoo force-pushed the split-needless-lifetimes branch 2 times, most recently from b874f45 to 50cc391 Compare January 30, 2025 19:00
@xFrednet xFrednet added S-final-comment-period Status: final comment period it will be merged unless new objections are raised (~1 week) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jan 31, 2025
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for addressing my previous comments :D

I've created an FCP

Roses are 'red,
Violets are 'blue,
Those lifetimes are,
needless and elidable,
but still needed,
for the poem flow,

@Alexendoo Alexendoo force-pushed the split-needless-lifetimes branch from eba6f78 to efcf1f5 Compare February 24, 2025 14:23
@xFrednet xFrednet added this pull request to the merge queue Feb 27, 2025
@xFrednet
Copy link
Member

The FCP has concluded (Sorry, for not following up on this earlier 🙈 )

Merged via the queue into rust-lang:master with commit f50266a Feb 27, 2025
11 checks passed
@Alexendoo Alexendoo deleted the split-needless-lifetimes branch February 28, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-final-comment-period Status: final comment period it will be merged unless new objections are raised (~1 week)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider splitting needless_lifetimes into cases that do and do not require '_
4 participants