Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update known problems for default_numeric_fallback #13794

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

Noratrieb
Copy link
Member

The existing known problem is not actually true, and the many false positives and false negatives should be mentioned.

Allowing the lint on a single statement: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=328de43690af13ed126f7c00c15cd695

changelog: [default_numeric_fallback]: update known problems docs

The existing known problem is not actually true, and the many false positives and false negatives should be mentioned.
@rustbot
Copy link
Collaborator

rustbot commented Dec 7, 2024

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 7, 2024
Copy link
Member

@Centri3 Centri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume this was added because it used to not use span_lint_hir_and_then. Thanks, good catch!

@Centri3 Centri3 added this pull request to the merge queue Dec 8, 2024
Merged via the queue into rust-lang:master with commit d1e1aff Dec 8, 2024
9 checks passed
@Noratrieb Noratrieb deleted the default_numeric_fallback branch December 8, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants