Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no_mangle_with_rust_abi: properly position the suggested ABI #13659

Merged
merged 1 commit into from
Nov 6, 2024
Merged

no_mangle_with_rust_abi: properly position the suggested ABI #13659

merged 1 commit into from
Nov 6, 2024

Conversation

samueltardieu
Copy link
Contributor

Fix #13656

changelog: [no_mangle_with_rust_abi]: properly position the suggested ABI

@rustbot
Copy link
Collaborator

rustbot commented Nov 5, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 5, 2024
blyxyas
blyxyas approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️ 🌈

@blyxyas
Copy link
Member

blyxyas commented Nov 6, 2024

Yeehaw 🤠

@bors
Copy link
Contributor

bors commented Nov 6, 2024

📌 Commit c1ab18d has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 6, 2024

⌛ Testing commit c1ab18d with merge f02a020...

@bors
Copy link
Contributor

bors commented Nov 6, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing f02a020 to master...

@bors bors merged commit f02a020 into rust-lang:master Nov 6, 2024
8 checks passed
@samueltardieu samueltardieu deleted the push-twtxmtvopoxo branch December 30, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken fix suggestion for no_mangle_with_rust_abi
4 participants
@samueltardieu @rustbot @blyxyas @bors