Skip use_self inside macro expansions of a impl Self block
#13128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
tesuji
force-pushed
the
fix_thread-local_use_self
branch
5 times, most recently
from
d02153a to
5d81633
Compare
Alexendoo
reviewed
Jul 24, 2024
tesuji
force-pushed
the
fix_thread-local_use_self
branch
from
5d81633 to
135eaf1
Compare
tesuji
changed the title
use_self inside thread_local! of a impl Self blockuse_self inside macro expansions of a impl Self block
tesuji
force-pushed
the
fix_thread-local_use_self
branch
from
135eaf1 to
d3d894d
Compare
|
Thank you for your insightful reviews! |
Alexendoo
reviewed
Aug 11, 2024
tesuji
force-pushed
the
fix_thread-local_use_self
branch
3 times, most recently
from
16f5ed8 to
451c584
Compare
|
☔ The latest upstream changes (presumably #13561) made this pull request unmergeable. Please resolve the merge conflicts. |
Alexendoo
approved these changes
Feb 1, 2025
Alexendoo
added
S-waiting-on-author
tesuji
force-pushed
the
fix_thread-local_use_self
branch
from
451c584 to
3cf2a7d
Compare
And use it in the next commit to avoid ICE.
tesuji
force-pushed
the
fix_thread-local_use_self
branch
from
3cf2a7d to
94f33cd
Compare
co-authored-by: Alex Macleod <[email protected]>
tesuji
force-pushed
the
fix_thread-local_use_self
branch
from
94f33cd to
9ea2b65
Compare
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
use_self] Skip if inside macro expansions of aimpl SelfblockFixes #13092.
r? Alexendoo