Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPEEDTEST instructions and output #11325

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Aug 11, 2023

  • --nocapture hasn't been needed anymore since forever (even before ui_test)
  • the result was dividing by 1000 instead of the number of test runs, giving bogus (but still useful for the purpose) timing results.

changelog: fix SPEEDTEST instructions and output

@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2023

r? @flip1995

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 11, 2023
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Aug 11, 2023

📌 Commit cd8f12d has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 11, 2023

⌛ Testing commit cd8f12d with merge 75370e0...

@bors
Copy link
Contributor

bors commented Aug 11, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 75370e0 to master...

@bors bors merged commit 75370e0 into rust-lang:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants