Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Almost swapped #10177

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Almost swapped #10177

merged 2 commits into from
Feb 13, 2023

Conversation

chansuke
Copy link
Contributor

@chansuke chansuke commented Jan 8, 2023

Take over from #8945

Fix #8151


changelog: enhancement: [almost_swapped]: Now detects almost swaps using let statements
#10177

@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2023

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 8, 2023
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

@chansuke chansuke force-pushed the almost_swapped branch 4 times, most recently from c348dd1 to 0fdeacf Compare January 22, 2023 06:48
@chansuke chansuke requested a review from Alexendoo January 26, 2023 18:15
@chansuke chansuke requested a review from Alexendoo January 30, 2023 11:14
@chansuke chansuke requested a review from Alexendoo January 30, 2023 16:54
@chansuke chansuke force-pushed the almost_swapped branch 2 times, most recently from a26cadc to b211676 Compare February 7, 2023 08:44
@Alexendoo
Copy link
Member

Okay great, this looks good thanks. Could you do a squash and then we'll get it merged

@chansuke
Copy link
Contributor Author

@Alexendoo Thank you so much for your patience. I've updated the branch.

@Alexendoo
Copy link
Member

No worries, thanks again for the work

@bors r+

@bors
Copy link
Contributor

bors commented Feb 13, 2023

📌 Commit ebca1b5 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 13, 2023

⌛ Testing commit ebca1b5 with merge ac60dca...

@bors
Copy link
Contributor

bors commented Feb 13, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing ac60dca to master...

@bors bors merged commit ac60dca into rust-lang:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

almost_swapped with let
5 participants