Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning for trivially_copy_pass_by_ref in traits even when allowed #3992

Closed
j-browne opened this issue Apr 18, 2019 · 0 comments · Fixed by #4250
Closed

Warning for trivially_copy_pass_by_ref in traits even when allowed #3992

j-browne opened this issue Apr 18, 2019 · 0 comments · Fixed by #4250
Labels
C-bug Category: Clippy is not doing the correct thing

Comments

@j-browne
Copy link

Here is an example on the playground, which is using clippy 0.0.212 currently.

a and c both have the allow attribute, but it seems to be ignored for a, and the only difference is that it is within a trait. Moving the attribute to the trait or the crate allows a, but would also apply to any other fns in the trait.
@matthiaskrgr matthiaskrgr added the C-bug Category: Clippy is not doing the correct thing label Apr 19, 2019
@ghost ghost mentioned this issue Jul 3, 2019
Merged
bors added a commit that referenced this issue Jul 3, 2019
@bors
Auto merge of #4250 - mikerite:fix-3992, r=phansch
e490f49 
Fix allow bug in `trivially_copy_pass_by_ref`

Closes #3992

changelog: Fix allow bug in `trivially_copy_pass_by_ref`
@bors bors closed this as completed in #4250 Jul 3, 2019
danielrh added a commit to danielrh/rust-sdl2 that referenced this issue Aug 24, 2020
@danielrh
suppress dangerous clippy hints until rust-lang/rust-clippy#3992 is r…
e6eaae4 
…esolved
danielrh added a commit to danielrh/rust-sdl2 that referenced this issue Aug 24, 2020
@danielrh
suppress dangerous clippy hints until rust-lang/rust-clippy#3992 is r…
eaa01c5 
…esolved
sypwex pushed a commit to sypwex/rust-sdl2 that referenced this issue Jun 2, 2024
@danielrh
suppress dangerous clippy hints until rust-lang/rust-clippy#3992 is r…
fbc7835 
…esolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: Clippy is not doing the correct thing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix allow bug in trivially_copy_pass_by_ref
2 participants
@matthiaskrgr @j-browne