Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize macro_vis_matcher #1096

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

jkozlowski
Copy link
Contributor

Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we should wait for the Rust PR to get approved before merging?

@jkozlowski
Copy link
Contributor Author

I think so, although this is my first time contributing, so not sure what the protocol is :)

kennytm added a commit to kennytm/rust that referenced this pull request Aug 21, 2018
…her, r=cramertj

Stabilize macro_vis_matcher

This PR should stabilize [macro_vis_matcher](rust-lang#41022) feature.

- [ ] "reference" book changes: rust-lang/reference#400
- [ ] "Rust by example" book changes: rust-lang/rust-by-example#1096
- [ ] "clippy" changes: rust-lang/rust-clippy#3055

r? @cramertj
@frewsxcv frewsxcv merged commit 8210d18 into rust-lang:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants