Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cexpr dependency #1390

Closed
wants to merge 1 commit into from
Closed

Update cexpr dependency #1390

wants to merge 1 commit into from

Conversation

kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Sep 18, 2018

This bumps nom from 0.3 to nom 0.4 internally. Note that 3 tests started to fail due to that change:

failures:

---- header_issue_674_1_hpp stdout ----
thread 'header_issue_674_1_hpp' panicked at 'libclang error; possible causes include:
- Invalid flag syntax
- Unrecognized flags
- Invalid flag arguments
- File I/O errors
If you encounter an error missing from this list, please file an issue or a PR!', libcore/option.rs:989:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- header_issue_674_2_hpp stdout ----
thread 'header_issue_674_2_hpp' panicked at 'libclang error; possible causes include:
- Invalid flag syntax
- Unrecognized flags
- Invalid flag arguments
- File I/O errors
If you encounter an error missing from this list, please file an issue or a PR!', libcore/option.rs:989:5

---- header_issue_674_3_hpp stdout ----
thread 'header_issue_674_3_hpp' panicked at 'libclang error; possible causes include:
- Invalid flag syntax
- Unrecognized flags
- Invalid flag arguments
- File I/O errors
If you encounter an error missing from this list, please file an issue or a PR!', libcore/option.rs:989:5


failures:
    header_issue_674_1_hpp
    header_issue_674_2_hpp
    header_issue_674_3_hpp

test result: FAILED. 425 passed; 3 failed; 0 ignored; 0 measured; 0 filtered out

The other dependencies that need updating are:

  • clang-sys
  • proc-macro2
  • quote
  • which

@emilio
Copy link
Contributor

emilio commented Sep 18, 2018

Hmm, do we have any idea of why the regressions? They don't make much sense to me, there's no chance that we've ran cexpr so early in the process I think...

@emilio
Copy link
Contributor

emilio commented Oct 4, 2018

Ok, so I looked at the regression, it's a nom or shlex regression. But it's test-only, fwiw. So I'll update the tests and get this landed.

@emilio emilio mentioned this pull request Oct 4, 2018
bors-servo pushed a commit that referenced this pull request Oct 4, 2018
Update some crates

This lands #1390 with some test fixes and a clang-sys update.

Part of #1407.

Closes #1390.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants