Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: do not drop errors from cargo metadata/check #8355

Merged
merged 7 commits into from
Apr 6, 2021
Merged

internal: do not drop errors from cargo metadata/check #8355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aaa8c20
internal: do not drop errors from cargo metadata/check
matklad Apr 5, 2021
9ca5973
Improve readability
matklad Apr 6, 2021
3698b3e
Avoid duplicate `cargo check`s
matklad Apr 6, 2021
e3c47cc
Use autoreload config to gate execution rather that staleness
matklad Apr 6, 2021
9143e39
Prepare for more stateless status reporting
matklad Apr 6, 2021
8fe20b1
More robust status notifications
matklad Apr 6, 2021
ad02bfe
Sacrifice for the semicolon god
matklad Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Sacrifice for the semicolon god
  • Loading branch information
@matklad
matklad committed Apr 6, 2021
commit ad02bfe58fd52293d9ae4a049f98f475df9d3abb
4 changes: 2 additions & 2 deletions editors/code/src/ctx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,13 @@ export class Ctx {
this.statusBar.color = undefined;
break;
case "warning":
this.statusBar.tooltip += "\nClick to reload."
this.statusBar.tooltip += "\nClick to reload.";
this.statusBar.command = "rust-analyzer.reloadWorkspace";
this.statusBar.color = new vscode.ThemeColor("notificationsWarningIcon.foreground");
icon = "$(warning) ";
break;
case "error":
this.statusBar.tooltip += "\nClick to reload."
this.statusBar.tooltip += "\nClick to reload.";
this.statusBar.command = "rust-analyzer.reloadWorkspace";
this.statusBar.color = new vscode.ThemeColor("notificationsErrorIcon.foreground");
icon = "$(error) ";
Expand Down
6 changes: 3 additions & 3 deletions editors/code/src/lsp_ext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ export const analyzerStatus = new lc.RequestType<AnalyzerStatusParams, string, v
export const memoryUsage = new lc.RequestType0<string, void>("rust-analyzer/memoryUsage");

export interface ServerStatusParams {
health: "ok" | "warning" | "error"
quiescent: boolean
message?: string
health: "ok" | "warning" | "error";
quiescent: boolean;
message?: string;
}
export const serverStatus = new lc.NotificationType<ServerStatusParams>("experimental/serverStatus");

Expand Down