Add full pattern completions for Struct and Variant patterns #6964
+363
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
commented
Dec 20, 2020
matklad
reviewed
Dec 22, 2020
matklad
reviewed
Dec 22, 2020
Comment on lines
41
to
45
| if let Some(snippet_cap) = ctx.snippet_cap() { | ||
| completion = completion.insert_snippet(snippet_cap, pat); | ||
| } else { | ||
| completion = completion.insert_text(pat); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if let Some(snippet_cap) = ctx.snippet_cap() { | |
| completion = completion.insert_snippet(snippet_cap, pat); | |
| } else { | |
| completion = completion.insert_text(pat); | |
| } | |
| completion = if let Some(snippet_cap) = ctx.snippet_cap() { | |
| completion.insert_snippet(snippet_cap, pat); | |
| } else { | |
| completion.insert_text(pat); | |
| } |
we need an 💡 for this
matklad
reviewed
Dec 22, 2020
|
bors r=matklad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just gonna call it full pattern completion as pattern completion is already implemented in a sense by showing idents in pattern position. What this does is basically complete struct and variant patterns where applicable(function params, let statements and refutable pattern locations).
This does not replace just completing the corresponding idents of the structs and variants, instead two completions are shown for these, a completion for the ident itself and a completion for the pattern(if the pattern make sense to be used that is). I figured in some cases one would rather type out the pattern manually if it has a lot of fields but you only care about one since this completion would cause one more work in the end since you would have to delete all the extra matched fields again.
These completions are tagged as
CompletionKind::Snippet, not sure if that is the right one here.some gifs