Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when the used toolchain looks too old for rust-analyzer #19244

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 27, 2025

Closes #18730

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2025
@Veykril Veykril added this pull request to the merge queue Mar 3, 2025
/// Any toolchain less than this version will likely not work with rust-analyzer built from this revision.
pub const MINIMUM_SUPPORTED_TOOLCHAIN_VERSION: semver::Version = semver::Version {
major: 1,
minor: 78,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of arbitrarily picked this fwiw, I think this was the last one we mentioned somewhere before so

Merged via the queue into rust-lang:master with commit 8ff0b67 Mar 3, 2025
9 checks passed
@Veykril Veykril deleted the push-nmnrnlysvyvk branch March 3, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define our minimal supported rust version and warn if it is not met
2 participants