Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: analysis-stats: respect --disable-proc-macros flag #18157

Conversation

davidbarsky
Copy link
Contributor

I noticed that this flag wasn't being respected by analysis-stats when profiling proc macro expansion, so here's a small fix.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2024
@Veykril
Copy link
Member

Veykril commented Sep 24, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2024

📌 Commit ad52c46 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 24, 2024

⌛ Testing commit ad52c46 with merge b6b56d2...

@bors
Copy link
Contributor

bors commented Sep 24, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing b6b56d2 to master...

@bors bors merged commit b6b56d2 into rust-lang:master Sep 24, 2024
11 checks passed
@lnicola lnicola changed the title analysis-stats: respect --disable-proc-macros flag internal: analysis-stats: respect --disable-proc-macros flag Sep 26, 2024
@davidbarsky davidbarsky deleted the davidbarsky/respect-disabling-proc-macros-in-analysis-stats branch November 21, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants