Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run flycheck on startup unless checkOnSave is enabled #13981

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 18, 2023

The main reason people disable it is because they don't want the expensive checks to occur automatically, so we shouldn't trigger them at the start up either if this is disabled.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 18, 2023
@Veykril
Copy link
Member Author

Veykril commented Jan 18, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jan 18, 2023

📌 Commit c9d33cd has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 18, 2023

⌛ Testing commit c9d33cd with merge 93c8ae0...

@bors
Copy link
Contributor

bors commented Jan 18, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 93c8ae0 to master...

@bors bors merged commit 93c8ae0 into rust-lang:master Jan 18, 2023
@Veykril Veykril deleted the saveOnCheckStartup branch January 18, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants