Import Quick fix should sort items from the current workspace before items from external crates

[joshka]

In ratatui, performing the Import <type> quick fix on Color shows: color_eyre::owo_..., another color_eyre import, ratatui::style::Color, then a crossterm import. The order that I want always is current crate types first, then alphabetical. The sort order seems pretty random right now.

Why? Ctrl+., Enter Enter should be muscle memory

Even better might be to add an extra quick fix if there are crate imports that match as well as external imports: e.g.:

Should have the same option to 'ratatui::style::Color` as this does:

Why? Different UI modality (menu vs popup) for the same action (add an import from this crate). They should be the same where possible to make muscle memory / defaults just work. Right now the popup is jarring as there's no general way to guess if you're going to hit one or the other until you actually view the result (assuming your hands are typing ahead rather than responding to what you see on the screen).

Does this sound like a reasonable heuristic? Is "one of the imports is in this workspace" something that can be determined while getting the list of valid imports?

[mathew-horner]

There are heuristics that handle the sort order, but in terms of preference for your code it seems to stop at the crate boundary. (link) It probably makes sense to make preference for workspace items somewhere between crate and std?

[joshka]

It took me a minute to work out why my example for this was not picking up the same crate logic. This code was in an example, so it's not in the same crate technically.