Extension activates when running build tasks

[adam-fowler]

Open any workspace and regardless of what is in the workspace the rust-analyser extension activates.

rust-analyzer version: 0.3.1418-standalone (4e29820f6 2023-02-26)

[lnicola]

Our activation events are:

{
     "activationEvents": [
         "onLanguage:rust",
         "onCommand:rust-analyzer.analyzerStatus",
         "onCommand:rust-analyzer.memoryUsage",
         "onCommand:rust-analyzer.reloadWorkspace",
         "onCommand:rust-analyzer.startServer",
         "workspaceContains:*/Cargo.toml",
         "workspaceContains:*/rust-project.json"
     ]
}

I'm not sure it would start in your situation.

[adam-fowler]

Well whenever I press Cmd+Shift+B. The rust build tasks are available. I also get an error message saying rust-analyzer failed to discover workspace

[lnicola]

That command also activates the CMake extension. It might be that Code activates every extension that exposes a build task.

[adam-fowler]

The runtime status has

Activation Event: onTaskType:cargo

Ok this might be a vscode issue

[adam-fowler]

Just found this microsoft/vscode#175821

[lnicola]

Yeah, looks like the same issue. I think we can close this one since there's nothing we can do.

[be5invis]

@lnicola still exists in 1.76.1 (which claims fixed microsoft/vscode#175821). May need further investigation.

[lnicola]

Looks like this might have been properly fixed in microsoft/vscode#178679.

[regadas]

I believe this is still hapenning with 1.78 and https://github.com/microsoft/vscode/pull/178679 seems to have been reverted microsoft/vscode@558ad31

[arnoson]

This still happens to me (in a platform-io project using c++/arduino code)

[alexandru-dinu]

Still happens.

In my case, I have a simple shell task for code formatting (labelled python-formatting) bound to a keymap. If I run the task via the command palette with Tasks: Run Task > python-formatting, the task runs fine and rust-analyzer does not load. However, if I run the task using the keymap, then rust-analyzer loads and fails with:

rust-analyzer failed to discover workspace

The keymap is defined as:

{
    "key": "ctrl+shift+i",
    "command": "workbench.action.tasks.runTask",
    "args": "python-formatting"
}

which I believe also runs other tasks and not only the one specified in args.

[rafales]

Will just leave it here:

runTask accepts a type argument which can be used to filter down tasks and avoid activating unnecessary extensions:

          {
            "command": "workbench.action.tasks.runTask",
            "args": {
              "type": "shell",
              "task": "Git Commit"
            }
          }

[larsch]

microsoft/vscode#175821 was fixed, closed and then reverted without comment, so the issue remains.

I've created microsoft/vscode#192043, since the original is locked.

[lnicola]

microsoft/vscode#192043 is also fixed, does this still happen?