Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#DK Activates on SHIFT+CTRL+B when no .NET assets present #1246

Closed
timheuer opened this issue Jun 26, 2024 · 2 comments
Closed

C#DK Activates on SHIFT+CTRL+B when no .NET assets present #1246

timheuer opened this issue Jun 26, 2024 · 2 comments
Labels
bug Something isn't working external External to this extension

Comments

@timheuer
Copy link
Member

timheuer commented Jun 26, 2024

Describe the Issue

The C# Dev Kit extension is activating unnecessarily when no .NET assets are present in the workspace, causing confusion and conflict for non-.NET project workspaces.

ctrlshiftb-activates.mp4

Steps To Reproduce

  1. Install C# Dev Kit (and .NET SDK) + C++ Extension pack
  2. Close any workspaces and reload window (to be clear of any activated extensions)
  3. create a new text file (foo.cpp)
  4. Open "Developer: Show Active Extensions"
  5. OBSERVE: C#/C#DK is not active, no .NET project is open in workspace, no csproj/razor/cs files open/active
  6. CTRL+SHIFT+B
  7. OBSERVE: C#/C#DK suddenly get activated, output logs open up and shows events activating the language extension and retrieving razor packages if not present
  8. Opening the extension host log:
    2024-06-26 10:04:52.276 [info] ExtensionService#_doActivateExtension vscode.grunt, startup: false, activationEvent: 'onTaskType:grunt'
    2024-06-26 10:04:52.288 [info] ExtensionService#_doActivateExtension vscode.gulp, startup: false, activationEvent: 'onTaskType:gulp'
    2024-06-26 10:04:52.295 [info] ExtensionService#_doActivateExtension vscode.jake, startup: false, activationEvent: 'onTaskType:jake'
    2024-06-26 10:04:52.301 [info] ExtensionService#_doActivateExtension vscode.npm, startup: false, activationEvent: 'onTaskType:npm'
    2024-06-26 10:04:52.338 [info] ExtensionService#_doActivateExtension vscode.typescript-language-features, startup: false, activationEvent: 'onTaskType:typescript'
    2024-06-26 10:04:52.424 [info] ExtensionService#_doActivateExtension ms-dotnettools.csharp, startup: false, activationEvent: 'onTaskType:dotnet', root cause: ms-dotnettools.csdevkit
    2024-06-26 10:04:52.555 [info] ExtensionService#_doActivateExtension ms-vscode.cmake-tools, startup: false, activationEvent: 'onTaskType:cmake'
    2024-06-26 10:04:52.924 [info] ExtensionService#_doActivateExtension ms-dotnettools.csdevkit, startup: false, activationEvent: 'onTaskType:dotnet'

Expected Behavior

C# Dev Kit should not activate in non .NET-scenarios

Environment Information

VS Code Extensions
ms-dotnettools.csdevkit: 1.8.10
ms-dotnettools.csharp: 2.35.15

@timheuer timheuer added the bug Something isn't working label Jun 26, 2024
@AbhitejJohn AbhitejJohn added area-project Project load, Solution Explorer area-extensionmanagement labels Jun 26, 2024
@timheuer
Copy link
Member Author

Closing my own bug here as external. Confirming that VSCode is tracking primary issue as: microsoft/vscode#192043

@timheuer timheuer added external External to this extension and removed area-project Project load, Solution Explorer area-extensionmanagement labels Jun 26, 2024
@timheuer timheuer closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external External to this extension
Projects
None yet
Development

No branches or pull requests

2 participants