Skip to content

Commit

Permalink
Merge #4769
Browse files Browse the repository at this point in the history
4769: Fix Run lens. r=matklad a=vsrs

This PR fixes a bug introduced in #4710: second and all subsequent clicks on the Run lens produce invalid commands:

1. `cargo test --package ra_ide --lib -- hover::tests::test_hover_enum_has_impl_action --exact --nocapture`
2. `cargo test --package ra_ide --lib -- hover::tests::test_hover_enum_has_impl_action --exact --nocapture` **`-- hover::tests::test_hover_enum_has_impl_action --exact --nocapture`**
3. `cargo test --package ra_ide --lib -- hover::tests::test_hover_enum_has_impl_action --exact --nocapture` **`-- hover::tests::test_hover_enum_has_impl_action --exact --nocapture -- hover::tests::test_hover_enum_has_impl_action --exact --nocapture`**

Co-authored-by: vsrs <[email protected]>
  • Loading branch information
bors[bot] and vsrs authored Jun 6, 2020
2 parents a609336 + b91fa74 commit d4a92b4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion editors/code/src/run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export function createTask(runnable: ra.Runnable): vscode.Task {
switch (runnable.kind) {
case "cargo": command = toolchain.getPathForExecutable("cargo");
}
const args = runnable.args.cargoArgs;
const args = [...runnable.args.cargoArgs]; // should be a copy!
if (runnable.args.executableArgs.length > 0) {
args.push('--', ...runnable.args.executableArgs);
}
Expand Down

0 comments on commit d4a92b4

Please sign in to comment.