Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention syntax ambiguity for eRFC 2947. #437

Merged
merged 2 commits into from
Oct 3, 2018
Merged

Mention syntax ambiguity for eRFC 2947. #437

merged 2 commits into from
Oct 3, 2018

Conversation

davidtwco
Copy link
Member

src/expressions/if-expr.md Outdated Show resolved Hide resolved
Havvy
Havvy previously requested changes Oct 2, 2018
Copy link
Contributor

@Havvy Havvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small things on wording. Actual content looks good to me.

src/expressions/if-expr.md Outdated Show resolved Hide resolved
@@ -111,6 +111,27 @@ match EXPR {
}
```

If the expression is a [lazy boolean operator expression][_LazyBooleanOperatorExpression_] then
this is a error as it is ambiguous which is problematic for the implementation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave out the "which is problematic". Just state it's ambiguous with a planned future change in the language.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this.

@davidtwco

This comment has been minimized.

@Centril
Copy link
Contributor

Centril commented Oct 3, 2018

Thanks!

@Centril Centril merged commit 9214ce6 into rust-lang:master Oct 3, 2018
@davidtwco davidtwco deleted the erfc-2947-documentation branch October 3, 2018 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants