Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Cleanup & add webfonts #25

Merged
merged 4 commits into from
Apr 16, 2014
Merged

Cleanup & add webfonts #25

merged 4 commits into from
Apr 16, 2014

Conversation

adrientetar
Copy link
Contributor

  • Switch to Jekyll templating
  • Cleanup some HTML markup
  • Make it responsive
  • CSS tweaks and redundancy fixes
  • Fix some metrics
  • Add Fira Sans webfont (300, 400, 500)
  • Import back latest bootstrap.css and clean it up

http://adrientetar.github.io/rust-www

r? @brson

- Switch to Jekyll templating
- Cleanup some HTML markup
- Make it responsive
- Fix some metrics
- Add Fira webfont
@brson
Copy link
Contributor

brson commented Apr 13, 2014

Looks awesome on android! Will follow up tomorrow.

@brson
Copy link
Contributor

brson commented Apr 14, 2014

The only thing I don't like here is the extent of the right hand columns in install.html. In the current one there are 1 column gutters both the left and right. In this revision it is only on the left, and the right hand extends all the way into the final column, making the page look unbalanced.

@adrientetar
Copy link
Contributor Author

Markup is okay but the tables are overflowing the container a bit because of the fixed width specified on them. I will see if I can rip that off.

@adrientetar
Copy link
Contributor Author

@brson Updated. ⭐

@brson
Copy link
Contributor

brson commented Apr 15, 2014

@adrientetar This illustrates what I am talking about: http://imgur.com/C8nBOi5

Currently, there are equalish-sized margins on the left and right. The new has no right-hand margin.

@brson brson merged commit 37fccbc into rust-lang:gh-pages Apr 16, 2014
@brson
Copy link
Contributor

brson commented Apr 16, 2014

I merged this with the slight change that I pushed the headers all the way into the last column.

@adrientetar
Copy link
Contributor Author

@brson Thanks, can you r+ rust-lang/rust#13484 also?

bors added a commit to rust-lang/rust that referenced this pull request Apr 17, 2014
- Cherry-pick from #12996
- Use Fira Sans for headlines and sidebar (Light), Heuristica for the body (Adobe Utopia derivative). Both are licensed under the SIL OFL license.
- A few tweaks

Two examples: [modified `std`](http://adrientetar.legtux.org/cached/rust-docs/std.htm) and [modified `std::io`](http://adrientetar.legtux.org/cached/rust-docs/io.htm).

cc #13484
**Blocked on rust-lang/prev.rust-lang.org#25 (for hosting of the fonts), that's showcased [here](http://adrientetar.github.io/rust-www/).**

cc @brson, @thehydroimpulse
alexcrichton pushed a commit that referenced this pull request Oct 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants