Generically implement fn horizontal_{and,or,xor}
#199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
...well, that didn't happen locally. |
|
I do not think that segfault is the fault of this PR's code, because we've been having random segfaults on rust-lang/rust also (see rust-lang/rust#90812) and it didn't even get as far as running the tests. ( Also rerunning it doesn't repeat it. ) |
workingjubilee
changed the title
horizontal_{and,or,xor}
workingjubilee
changed the title
horizontal_{and,or,xor}fn horizontal_{and,or,xor}
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
20kb off, and it makes the docs significantly less crowded.
Implementation here depends on both
SelfandTimplementing theBit{Op}trait in question (so that it's coherent to reason about it as equivalent to a manual implementation where it does a series of vectorBit{Op}s and then a final fold ofBit{Op}s on essentiallyIterator<Item=T>).