Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend tests to cover the insensitive analysis #96

Merged
merged 3 commits into from
Dec 28, 2018
Merged

extend tests to cover the insensitive analysis #96

merged 3 commits into from
Dec 28, 2018

Conversation

nikomatsakis
Copy link
Contributor

r? @lqd

nikomatsakis
nikomatsakis commented Dec 27, 2018
View reviewed changes
lqd
lqd approved these changes Dec 27, 2018
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

We can either add that Naive errors must be a subset of LocationInsensitive errors here, or do it later!

@lqd
Copy link
Member

lqd commented Dec 27, 2018

(nice of github to show the comment more than once)

@nikomatsakis
Copy link
Contributor Author

Rebased, added subset.

@nikomatsakis nikomatsakis merged commit b388c4e into rust-lang:master Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikomatsakis @lqd