Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the Naive variant to leapjoin #92

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Conversation

lqd
Copy link
Member

@lqd lqd commented Dec 6, 2018

On the clap dataset:

  • before: around 30s
  • after: around 23.2s

r? @nikomatsakis

Once datafrog relaxes the leapjoin well-formedness check, we'll be able to port a couple more joins (and remove a big index). The other remaining joins are between dynamic variables, which datafrog leapjoins won't support for at least a while.

Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me =) I'd like to merge the tests first

On the `clap` dataset:
- before: around 30s
- after: around 23.2s

Once datafrog relaxes the leapjoin well-formedness check, we'll be able to port a couple more joins (and remove a big index). The other remaining joins are between dynamic variables, which datafrog leapjoins won't support for at least a while.
@nikomatsakis nikomatsakis merged commit 3ed4378 into rust-lang:master Dec 7, 2018
@lqd lqd deleted the naive_frog branch December 7, 2018 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants