March garden maintenance #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
approved these changes
Apr 28, 2021
|
this looks good! r=me |
nikomatsakis
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
polonius-parsertolalrpop0.19.5, to remove some dependenciesnon_fmt_panicwarnings triggered in a couple of our test assertions(there's still another warning that I didn't fix: the
Context::potential_errorsfield is still unused, until I complete the work on sharing the results between theLocationInsensitiveandDatafrogOptvariants to optimize the latter, and which should hopefully happen soon-ish)(This was mostly to reduce compile times, which are lowered by 15-20s with this PR on my machine)