Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up terminology: step 3 — the rest of the owl #155

Merged
merged 17 commits into from
Apr 28, 2021

Conversation

lqd
Copy link
Member

@lqd lqd commented Dec 20, 2020

Completes most of The Great Renaming™ to also align:

  • input relations and .facts files (borrow_region to loan_issued_at, killed to loan_killed_at, invalidates to loan_invalidated_at, outlives to subset_base)
  • some of the effects in the test parser mentioning the previous input relations
  • the data computed by the variants ( requires relation to origin_contains_loan_on_entry, borrow_live_at to loan_live_at) and the API accessing this data
  • some debug output relations (which used the very old restricts instead of requires, now use origin_contains_loan_*)
  • (also removes an unused dataset)

with the naming plan in our rules hackmd.

This PR will need require rustc's fact generation to be updated to use these new names as well.

For review purposes: since there's a lot of renaming, each commit can be reviewed individually. Note that the commits renaming the datasets' fact files are prefixed with "tests".

@nikomatsakis
Copy link
Contributor

this is amazing and you are a hero. do you want me to merge this now, @lqd, or do you have a particular ordering?

@lqd
Copy link
Member Author

lqd commented Apr 28, 2021

@nikomatsakis this one was the one I planned we'd merge first :)

@nikomatsakis nikomatsakis merged commit 3f74c2c into rust-lang:master Apr 28, 2021
@nikomatsakis
Copy link
Contributor

DONE

@lqd lqd deleted the great_renaming_2020 branch April 28, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants