-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up terminology: step 3 — the rest of the owl #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fixes parts of a comment which were now incorrect
This helps with readability
…oan_*` and similarly, a couple of methods in the `Output` API mentioning "borrows" or "regions" were modernized
This was referenced Dec 21, 2020
nikomatsakis
approved these changes
Apr 28, 2021
this is amazing and you are a hero. do you want me to merge this now, @lqd, or do you have a particular ordering? |
@nikomatsakis this one was the one I planned we'd merge first :) |
DONE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes most of The Great Renaming™ to also align:
borrow_region
toloan_issued_at
,killed
toloan_killed_at
,invalidates
toloan_invalidated_at
,outlives
tosubset_base
)requires
relation toorigin_contains_loan_on_entry
,borrow_live_at
toloan_live_at
) and the API accessing this datarestricts
instead ofrequires
, now useorigin_contains_loan_*
)with the naming plan in our rules hackmd.
This PR will need require rustc's fact generation to be updated to use these new names as well.
For review purposes: since there's a lot of renaming, each commit can be reviewed individually. Note that the commits renaming the datasets' fact files are prefixed with "tests".