Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace fact type parameters with FactTypes #130

Merged
merged 4 commits into from
Oct 3, 2019
Merged

replace fact type parameters with FactTypes #130

merged 4 commits into from
Oct 3, 2019

Conversation

csmoe
Copy link
Member

@csmoe csmoe commented Sep 23, 2019

Closes #111

nikomatsakis
nikomatsakis reviewed Sep 24, 2019
View reviewed changes
@shepmaster shepmaster changed the title [WIP] replace fact type parameters with Factypes [WIP] replace fact type parameters with FactTypes Sep 24, 2019
@csmoe csmoe force-pushed the factypes branch 2 times, most recently from 16351fd to 270e7db Compare September 25, 2019 16:21
@csmoe csmoe changed the title [WIP] replace fact type parameters with FactTypes replace fact type parameters with FactTypes Sep 25, 2019
@csmoe
Copy link
Member Author

csmoe commented Sep 25, 2019

clones cleaned up
r? @nikomatsakis

@nikomatsakis nikomatsakis merged commit c9ecc9b into rust-lang:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandasystems amandasystems amandasystems left review comments

@nikomatsakis nikomatsakis nikomatsakis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace "fact" type parameters with associated types
3 participants
@csmoe @amandasystems @nikomatsakis