Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to rustc sanity check branch #381

Merged
merged 6 commits into from
Jul 30, 2018
Merged

Update to rustc sanity check branch #381

merged 6 commits into from
Jul 30, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jun 5, 2018

to be merged after rust-lang/rust#51361 hits nightly

@oli-obk oli-obk self-assigned this Jun 5, 2018
@oli-obk oli-obk force-pushed the sanity_checks branch 2 times, most recently from b8147ed to 062cf07 Compare July 17, 2018 15:53
@RalfJung
Copy link
Member

I updated this to also fix the breakage from promoteds being a place.

However, two compile-fail tests fail: A bad bool is no longer detected on an if, and modifying_constants.rs also just runs to completion.

@RalfJung
Copy link
Member

RalfJung commented Jul 24, 2018 •
edited
Loading

Yeah the bool part is ensure_valid_value being removed.

I have plans for a more consistent version of this so I guess it's okay for that to be removed, but why is it not even detected when an if actually happens?

EDIT: Ah, the MIR actually uses switchInt(move _2) -> [false: bb2, otherwise: bb1] so it does not care.

@RalfJung
Copy link
Member

Note to self and everybody whom it concerns: Do NOT force-push to this branch or delete it before it was merged! It is referenced by rustc.

(Might be worth stating that also in the future as it's kind of not clear just looking at this PR.^^)

oli-obk and others added 5 commits July 26, 2018 11:21
@oli-obk
Update to rustc sanity check branch
53114e3
@RalfJung @oli-obk
make miri compile again
e849fa4
@RalfJung @oli-obk
Ignore tests
b7c57fe 
the bool thing will be fixed by the validation I have planned, and we already ignored another test around modifing constants.
@oli-obk
Disable blood letting edge features
305d8ae
@oli-obk
Bump min dependency version
e6f1e15
@RalfJung RalfJung merged commit 471944b into master Jul 30, 2018
@RalfJung RalfJung deleted the sanity_checks branch July 30, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oli-obk @RalfJung