-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miri rename undef uninit #1487
Miri rename undef uninit #1487
Conversation
This looks good, thanks. :) |
I will check the build on my local machine, using rustc with the changes made in the previously mentioned PR |
The local build I did of Miri, using the steps defined here compiled successfully using the changes made in this pull request. |
Awesome, thanks for checking that :) |
@pnadon can you extend this PR to update the |
@RalfJung it should be the hash for the commit below, correct? |
Yes, the hash of latest master. |
It seems as though there is a conflict due to someone changing the |
Ah good point... that someone is probably me. ;) |
to Immediate::to_scalar_or_uninit in src/shims/intrinsics.rs related issue #71193
Updated Rust version since the latest version contains changes which allow this version of Miri to build.
@RalfJung done! |
@pnadon CI isn't happy, something is not building:
|
Due to changes from upstream, a commit using not_undef was inserted, which had to be updated to use check_init. related issue #71193
I checked just now, and the error was due to upstream insertions, one of which used "not_undef". The latest commit fixes this. |
Thanks. :) |
📌 Commit 6dd700f has been approved by |
☀️ Test successful - checks-travis, status-appveyor |
The changes made here are related to issue #71193 on Rust, and the pull request 74664 on Rust.
ScalarMaybeUninit::not_undef
tocheck_init
Immediate::to_scalar_or_undef
toImmediate::to_scalar_or_uninit