We have no test which checks whether write_aggregate resets storage to uninit
#3195
Comments
bors
added a commit
that referenced
this issue
Nov 30, 2023
miri: add test checking that aggregate assignments reset memory to uninit Also, `write_aggregate` is really just a helper for evaluating `Aggregate` rvalues, so it should be in `step.rs`, not `place.rs`. Also factor out `Repeat` rvalues into their own function while we are at it. r? `@saethlin` Fixes #3195
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this issue
Apr 7, 2024
miri: add test checking that aggregate assignments reset memory to uninit Also, `write_aggregate` is really just a helper for evaluating `Aggregate` rvalues, so it should be in `step.rs`, not `place.rs`. Also factor out `Repeat` rvalues into their own function while we are at it. r? `@saethlin` Fixes rust-lang/miri#3195
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this issue
Apr 27, 2024
miri: add test checking that aggregate assignments reset memory to uninit Also, `write_aggregate` is really just a helper for evaluating `Aggregate` rvalues, so it should be in `step.rs`, not `place.rs`. Also factor out `Repeat` rvalues into their own function while we are at it. r? `@saethlin` Fixes rust-lang/miri#3195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After commenting out this line, the Miri test suite still passes (with
--bless).We clearly should have a test that actually checks that we reset the memory to "uninit".
The text was updated successfully, but these errors were encountered: