Skip to content

Commit

Permalink
Auto merge of #118548 - Enselic:bench-padding, r=thomcc,ChrisDenton
Browse files Browse the repository at this point in the history
libtest: Fix padding of benchmarks run as tests

### Summary

The first commit adds regression tests for libtest padding.

The second commit fixes padding for benches run as tests and updates the blessed output of the regression tests to make it clear what effect the fix has on padding.

Closes #104092 which is **E-help-wanted** and **regression-from-stable-to-stable**

### More details

Before this fix we applied padding _before_ manually doing what `convert_benchmarks_to_tests()` does which affects padding calculations. Instead use `convert_benchmarks_to_tests()` first if applicable and then apply padding afterwards so it becomes correct.

Benches should only be padded when run as benches to make it easy to compare the benchmark numbers. Not when run as tests.

r? `@ghost` until CI passes.
  • Loading branch information
bors committed Jan 12, 2024
2 parents 0553319 + a431dbb commit 508ca9a
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 508ca9a

Please sign in to comment.