-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add typos for CI, include typos.toml #2664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I don't really have much context here. Why are so many files being ignored? Also, I would expect some documentation in the contributing guide. For example: What happens if it has a false positive? How do I run this locally? |
Some of those ignored files had typos. I think at least one of those typos were fixed already. |
I'll look into which files still have typos tomorrow. |
I've added a commit to the @ehuss The remaining files that are whitelisted are
Which to me don't make sense to include into typechecking. That leaves files like I'd be happy to add a section that mentions whitelisting a word if it runs into a false positive, if people here feel that's the most appropriate way forward. I can see this being annoying if certain coders are used to abbreviations in their style. |
@szabgab pinging since the label says it's waiting on me (author) but I've made changes that could benefit from feedback from reviewers. |
Addresses #2660