-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add cairo support to highlight.js #2468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Can you say how you generated this? I do not see cairo as a supported language in highlight.js 10.1. If it isn't one of the built-in languages, I don't think I would want to include it. I think you should be able to include it as a js extension. |
Tbh, I just manually modified the rust rule in the minified highlight.js, as cairo is based upon rust. I am fully aware that we can include our own JS extension with the mdBook result, and that's what we are actually doing right now. And it works. But the problem is that we don't actually run a mdBook for a user, so later on, the user has to replace the I also completely understand your concern. I will go and make a PR inside the |
Unfortunately that won't help for now, since we are stuck on an old version of highlight.js and can't update. |
So just to be clear, there is no way to directly add a custom language (one that isn't natively supported by 10.1 highlight.js) to mdBook's highlight.js file, right? |
Correct. |
☔ The latest upstream changes (possibly #2681) made this pull request unmergeable. Please resolve the merge conflicts. |
Hello!
We wanted to support a cairo inside the
highlight.js
. We use mdBook inside our build / package manager tool called Scarb, which has an option to generate markdown files with documentation and later be used by mdBook to generate a proper documentation html.