Use ctest2 instead of the original to fix warnings
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,5 +58,5 @@ stock-zlib = [] | |||
| # Deprecated: the assembly routines are outdated, and either reduce performance | |||
| # or cause segfaults. | |||
| asm = [] | |||
| # Enable this feature if you want to have a staticly linked libz | |||
| # Enable this feature if you want to have a statically linked libz | |||
There was a problem hiding this comment.
Would you mind splitting this into a separate commit?
|
One minor nit, and otherwise, I'd love to merge this. Thanks for the fix! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw Josh opened this issue: gnzlbg/ctest#99
That's because we use ctest v0.1 here, it's outdated a bit. We could fix this issue by updating it to v0.2 but it will emit uninitialized errors, like this: https://github.com/JohnTitor/libz-sys/runs/1014401885
So, if you want to get rid of the warnings, I'd recommend using ctest2, which is a fork of ctest and has some fixes: https://github.com/JohnTitor/ctest2
I created this to use on the libc crate, but I hope this helps here as well :)