add fdopendir #550
Merged
add fdopendir #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
commented
Mar 13, 2017
src/unix/mod.rs
Outdated
| @@ -328,6 +328,10 @@ extern { | |||
| #[cfg_attr(all(target_os = "macos", target_arch = "x86"), | |||
| link_name = "fdopen$UNIX2003")] | |||
| pub fn fdopen(fd: ::c_int, mode: *const c_char) -> *mut ::FILE; | |||
|
|
|||
| #[cfg(not(any(target_os = "macos", target_os = "ios")))] | |||
There was a problem hiding this comment.
Should I define this function here or in every os module except macos?
There was a problem hiding this comment.
Ah yeah let's just inline this definition in modules other than src/unix/bsd/apple
Mic92
force-pushed
the
fdopendir
branch
2 times, most recently
from
c3955ee to
192a036
Compare
|
@bors: r+ Thanks! |
|
📌 Commit 192a036 has been approved by |
|
💔 Test failed - status-travis |
|
@bors: retry
…On Mon, Mar 13, 2017 at 6:32 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/libc/builds/210727790>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#550 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95NGJBIWzRvrpbWYlDjYxC6s_r012ks5rldH3gaJpZM4MbOma>
.
|
|
💔 Test failed - status-travis |
|
@bors: retry
…On Tue, Mar 14, 2017 at 8:54 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/libc/builds/211191290>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#550 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95E0Ou9K5Pt95ATeN-ulDxqEgNXPYks5rl0TzgaJpZM4MbOma>
.
|
|
💔 Test failed - status-travis |
|
@bors: retry |
|
💔 Test failed - status-appveyor |
|
@bors: retry
…On Thu, Mar 23, 2017 at 3:37 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang-libs/libc/build/1.0.361>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#550 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95FujZ6X-oYFRfqF4WcvhaWgSPEK_ks5rotgggaJpZM4MbOma>
.
|
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #551) made this pull request unmergeable. Please resolve the merge conflicts. |
|
fixed merge conflict. |
|
@bors: r+ |
|
📌 Commit 99a524d has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.