-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve various CI issues #4254
Conversation
@tgross35: no appropriate reviewer found, use |
Recent versions of Rust require the ABI always be specified for `extern` functions, whereas it historically defaulted to `extern "C"`. Fix a few cases where this lint now gets raised by specifying `extern "C"`.
f381666
to
c9a71dc
Compare
This must be new |
On ppc Windows: |
That warning gets downgraded in rust-lang/rust#136098, we can wait for that. |
The FreeBSD failures look like rust-lang/cargo#15092 |
For the FreeBSD jobs, if rust-lang/cargo#15092 is the same issue, maybe disabling backtraces on cirrus could work? ci/run.sh defaults it to 1, but we should be able to explicitly pass 0 on it on .cirrus.yml:
|
Thanks for the writeup. I do plan to try that out, just haven't had a chance to circle back to this yet. |
Having this environment variable set causes a segfault [1]. Just disable backtraces for now. [1]: rust-lang/rust#132185
63d0b62
to
8d8a199
Compare
This field appears to have been added recently [1]. [1]: freebsd/freebsd-src@b4663a8
Fyi @asomers the third commit here adds a field to stat32 that seems to be new in FreeBSD 15 freebsd/freebsd-src@b4663a8. |
No idea what the PPC failure is about
I am going to disable that for now in order to get CI unstuck. |
As mentioned in [1], this test has started to fail for unclear reasons. Disable this until it can be investigated further. [1]: rust-lang#4254 (comment)
f436699
to
eb7045b
Compare
Fix the
missing_abi
lintRecent versions of Rust require the ABI always be specified for
extern
functions, whereas it historically defaulted toextern "C"
. Fix a few cases where this lint now gets raised by specifyingextern "C"
.Disable RUST_BACKTRACE for FreeBSD CI
Having this environment variable set causes a segfault rust-lang/rust#132185. Just disable backtraces for now.
FreeBSD: Add the new
st_filerev
field tostat32
for FreeBSD 15This field appears to have been added recently freebsd/freebsd-src@b4663a8.
Temporarily disable powerpc-unknown-linux-gnu tests
As mentioned in 1, this test has started to fail for unclear reasons. Disable this until it can be investigated further.