Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror c_char configuration from rust-lang/rust #4198

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

tgross35
Copy link
Contributor

Create a module providing the same definitions of c_char as in rust-lang/rust, which in most cases are based on the architecture rather than the OS. This will allow individual platforms to reexport the definition rather than having configuration repeated in numerous modules.

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

@tgross35: no appropriate reviewer found, use r? to override

@tgross35 tgross35 enabled auto-merge December 17, 2024 10:01
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Dec 17, 2024
@tgross35 tgross35 force-pushed the c_char-arch-definition branch 2 times, most recently from 758eb03 to 4aff9eb Compare December 17, 2024 10:59
@tgross35 tgross35 mentioned this pull request Dec 17, 2024
3 tasks
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@tgross35 tgross35 added this pull request to the merge queue Dec 17, 2024
@tgross35 tgross35 removed this pull request from the merge queue due to a manual request Dec 17, 2024
Create a module providing the same definitions of `c_char` as in
`rust-lang/rust`, which in most cases are based on the architecture
rather than the OS. This will allow individual platforms to reexport the
definition rather than having configuration repeated in numerous
modules.
@tgross35 tgross35 force-pushed the c_char-arch-definition branch from 4222a3c to 28d4064 Compare December 17, 2024 11:26
@tgross35 tgross35 enabled auto-merge December 17, 2024 11:26
@tgross35 tgross35 added this pull request to the merge queue Dec 17, 2024
Merged via the queue into rust-lang:main with commit 92ffa8c Dec 17, 2024
45 checks passed
@tgross35 tgross35 deleted the c_char-arch-definition branch December 17, 2024 12:10
@taiki-e taiki-e mentioned this pull request Dec 17, 2024
3 tasks
tgross35 added a commit to tgross35/rust-libc that referenced this pull request Dec 18, 2024
Create a module providing the same definitions of `c_char` as in
`rust-lang/rust`, which in most cases are based on the architecture
rather than the OS. This will allow individual platforms to reexport the
definition rather than having configuration repeated in numerous
modules.

(backport <rust-lang#4198>)
(cherry picked from commit 28d4064)
@tgross35 tgross35 mentioned this pull request Dec 18, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants