[0.2] Backports #4188
Closed
[0.2] Backports #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They aren't stable across OS versions, and they don't have any legitimate use in applications.
We have a handful of jobs that could benefit from reusing the target directory. Make use of Swatinem/rust-cache to do so. Something still isn't quite right since the largest job only seems to be restoring a portion of the cache, but this still shows an improvement for most jobs. (backport <rust-lang#4178>) (cherry picked from commit af7e126)
This lint was recently added so this change is needed to fix CI. The suggested alternative is to use `ptr::fn_addr_eq` which isn't available until 1.85, so allow the lint here. (backport <rust-lang#4177>) (cherry picked from commit 99f4dd9)
(backport <rust-lang#4179>) (cherry picked from commit cde5e54)
(backport <rust-lang#4179>) (cherry picked from commit 5b471ae)
Add these functions, similar to the Linux ones. Also add tests. For illumos, the source code is at [1] and documentation is at [2]. Blame suggests that Solaris also supports the same calls. [1]: https://github.com/illumos/illumos-gate/blame/27ecbff00d8c86a2647d6fe325cacb220d712115/usr/src/uts/common/sys/iso/signal_iso.h#L100-L101 [2]: https://illumos.org/man/3HEAD/signal.h (backport <rust-lang#4171>) (cherry picked from commit a8aaadf)
ref: https://github.com/torvalds/linux/blob/feffde684ac29a3b7aec82d2df850fbdbdee55e4/include/uapi/linux/mman.h#L20 (backport <rust-lang#4173>) (cherry picked from commit 40a4d33)
`PF_BLOCK_TS` and `PF_SUSPEND_TASK`. They are also added to the tests. Interestingly, `PF_SUSPEND_TASK` is already there somewhere in the build script 🤔 Signed-off-by: Paul Mabileau <[email protected]> (backport <rust-lang#4174>) (cherry picked from commit 6934e52)
Taken from <https://github.com/torvalds/linux/blob/2ba9f676d0a2e408aef14d679984c26373bf37b7/include/linux/sched.h#L1661\>. Signed-off-by: Paul Mabileau <[email protected]> (backport <rust-lang#4174>) (cherry picked from commit 9a38ea3)
They didn't seem to already exist, so add them. The new ones are included. Signed-off-by: Paul Mabileau <[email protected]> (backport <rust-lang#4174>) (cherry picked from commit 5997f35)
(backport <rust-lang#4185>) (cherry picked from commit 70c1e82)
(backport <rust-lang#4176>) (cherry picked from commit 6faa521) [ resolve conflicts and update based on some main vs. 0.2 differences - Trevor ]
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
rustbot
added
A-CI
|
Decided just to add the final commit to #4187. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the following: