Added extensive constants to make use of the BSD's sysctl function.

[raphaelcohn]

sysctl usage does differ significantly across the BSDs, and, whilst
some constants overlap, many do not. It is easier to maintain them
in separate modules, rather than trying to tease out common definitions.

[rust-highfive]

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

[alexcrichton]

Thanks! Looks like some of the CI failures are legitimate though?

[raphaelcohn]

OK will take a look in the morning...
On 11 May 2016 10:37 p.m., "Alex Crichton" [email protected] wrote:

Thanks! Looks like some of the CI failures are legitimate though?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#285 (comment)

[raphaelcohn]

OK, looks like I missed some duplicate definitions which had been added piecemeal. I'm beginning to wonder, even though it creates apparent duplication, whether it would be better to drop the attempt to create a hierarchy of unices and just push all definitions down to a per-OS file. It could make maintenance easier. Thoughts? Alternatively, a kickstarter campaign to flesh out all remaining libc bits and bobs... I'd be game for that.

[alexcrichton]

Heh, yeah the organization as-is may be a bit of an opportunistic optimization that may not be worth it in the end, but we probably don't want to shift it all around just yet.

[raphaelcohn]

Fair enough
On 12 May 2016 9:47 p.m., "Alex Crichton" [email protected] wrote:

Heh, yeah the organization as-is may be a bit of an opportunistic
optimization that may not be worth it in the end, but we probably don't
want to shift it all around just yet.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#285 (comment)

[alexcrichton]

Looks like travis is still having some problems though?

[raphaelcohn]

OK, I think I've fixed this. (I must say, I'm dead impressed with your CI builds. They're very effective).
Turns out the problem was I grepp'd for duplicate pub const KERN_PROC: but missed the ones pub const KERN_PROC :. Would this be worth an addition to the style checks?

[raphaelcohn]

OK, looks like we're just down to bitrig failing now...I'll try again...

[alexcrichton]

@bors: r+ 786d505

[bors]

⌛ Testing commit 786d505 with merge 72519bf...

[bors]

☀️ Test successful - status-appveyor, travis

[Nercury]

@raphaelcohn It looks like libc::HW_NCPU is now missing on auto-linux-64-cross-netbsd. Is this intentional? (issue here: rust-lang/rust#33500 (comment))

[alexcrichton]

Ah yeah that's accidentally, I'm adding it back in #291