Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus decision making #113

Merged
merged 10 commits into from
Nov 3, 2021

Conversation

joshtriplett
Copy link
Member

Add the decision-making process from the 2021-07-21 design meeting

All content from the design document. Minor fixes to formatting and
organization, minor wording corrections, and some clarifications and FAQ
entries. No changes to the actual process.

All content from the design document. Minor fixes to formatting and
organization, and minor wording corrections, but no changes to the
actual process.
src/decision_process.md Outdated Show resolved Hide resolved
@pnkfelix
Copy link
Member

The current set of examples only shows "reversible" and "irreverisble" based solely on rustbot inferring it (based on whether it is looking at a stabilization proposal).

I think there should be a concrete example of a team member using the command syntax that changes the state of the reversibility of a decision.

@pnkfelix
Copy link
Member

I found the use of the terms "mutable" and "immutable" confusing.

  • They don't occur in decision_process.md; only "reverisible"/"irreversible" occur there.
  • Where they did occur, it seems like they are synonyms for "reversible"/"irreverisible" ?

Assuming I am right about their role: Why have these synonyms? I think it would be clearer to pick one pair of terms and use them consistently.

joshtriplett and others added 6 commits October 13, 2021 00:00
Co-authored-by: Felix S Klock II <[email protected]>
Co-authored-by: Felix S Klock II <[email protected]>
Generalize to "does not speak for the entire team" rather than tabooing
the word "we". But also, rephrase to use "I think" phrasing instead of
"we have".
…ncerns

Try to make it clearer that we can and do still make irreversible
decisions. Focus on how we handle dissent in such cases, and what we can
do in those circumstances.
@joshtriplett
Copy link
Member Author

@pnkfelix Mostly, I think those terms felt both playful and memorable, given Rust's own use of mutability.

I would still like to keep those synonyms in bot commands, but I'll switch to consistently using reversible and irreversible in prose.

Keep "mutable"/"immutable" (and unambiguous prefixes) as synonyms, but
favor the more self-documenting terms in documentation.
@pnkfelix
Copy link
Member

pnkfelix commented Nov 1, 2021

@pnkfelix Mostly, I think those terms felt both playful and memorable, given Rust's own use of mutability.

I would still like to keep those synonyms in bot commands, but I'll switch to consistently using reversible and irreversible in prose.

(I don't mind playfulness; see e.g. the plethora of puns and/or cultural references I try to stuff into documents I write. But in the end, I also think "reversible/irreversible" are more precise, in terms of what we expect the state transitions to be, so 1. I wouldn't want to choose mutable/immutable over reversible/irreversible, and 2. I do think consistency is more important than playfulness.)

In any case, keeping the synonyms is fine, but please do document their existence as synonyms, so that people who use this as a reference document won't be as mystified as I am when they encounter their usage in the wild.

@joshtriplett
Copy link
Member Author

In any case, keeping the synonyms is fine, but please do document their existence as synonyms, so that people who use this as a reference document won't be as mystified as I am when they encounter their usage in the wild.

I did add them to the documentation as synonyms.

@pnkfelix
Copy link
Member

pnkfelix commented Nov 3, 2021

I did add them to the documentation as synonyms.

hup, yes you did! Sorry for responding before reading the current content.

This all looks great. r+ from me.

@joshtriplett joshtriplett merged commit 3b19d81 into rust-lang:master Nov 3, 2021
@joshtriplett joshtriplett deleted the consensus-decision-making branch November 3, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants