Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

26989 #39

Merged
merged 2 commits into from
Oct 24, 2015
Merged

26989 #39

merged 2 commits into from
Oct 24, 2015

Conversation

emoon
Copy link
Contributor

@emoon emoon commented Oct 24, 2015

No description provided.

steveklabnik added a commit that referenced this pull request Oct 24, 2015
@steveklabnik steveklabnik merged commit 2658734 into rust-lang:master Oct 24, 2015
@steveklabnik
Copy link
Member

@emoon can you maybe share the git commands you're using to make these PRs? I have a hunch...

@emoon
Copy link
Contributor Author

emoon commented Oct 25, 2015

I think I know what the problem is.

When I created a new branch for each PR I did it by doing:

git checkout -b
.. do stuff, PR, etc
git checkout -b

Instead of going back to master as base and branch from there.

@emoon emoon deleted the 26989 branch October 25, 2015 07:01
@steveklabnik
Copy link
Member

Ah ha! :)

Too bad that wasn't easier to figure out from GitHub's interface.

On Oct 25, 2015, at 02:28, Daniel Collin [email protected] wrote:

I think I know what the problem is.

When I created a new branch for each PR I did it by doing:

git checkout -b
.. do stuff, PR, etc
git checkout -b

Instead of going back to master as base and branch from there.


Reply to this email directly or view it on GitHub.

@emoon
Copy link
Contributor Author

emoon commented Oct 25, 2015

Yeah. Sorry about that, now the history looks like spagetti :)

history

I will make sure to switch to master before doing any more PRs so lesson learned but yes it would have been nice if the GitHub interface would have hinted about it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants