Add support for connected component traversal & reset #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some projects need the connected component traversal feature. However, that feature was removed from *ena* for performance reasons: preserving the data required for connected component traversal introduced an overhead that was unnecessary in the large majority of cases. (d0a8975) This PR reintroduces this as an optional feature through a type parameter on the `UnificationStore`. Because no extra data is stored when not using `ConnectedComponentTraversal`, this feature has no impact on performance when not used. **Benchmarks:** master: ``` test unify::tests::big_array_bench_InPlace ... bench: 499,038 ns/iter (+/- 2,306) test unify::tests::big_array_bench_clone_InPlace ... bench: 614,115 ns/iter (+/- 2,672) test unify::tests::big_array_bench_in_snapshot_InPlace ... bench: 741,977 ns/iter (+/- 24,403) ``` this branch: ``` test unify::tests::big_array_bench_InPlace ... bench: 467,384 ns/iter (+/- 10,037) test unify::tests::big_array_bench_clone_InPlace ... bench: 571,047 ns/iter (+/- 3,150) test unify::tests::big_array_bench_in_snapshot_InPlace ... bench: 740,714 ns/iter (+/- 7,666) ``` Compared to a feature, this design enables the library to be used simultaneously in both cases (connected component traversal required and not required), while benefiting from optimal performance in both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects need the connected component traversal feature.
However, that feature was removed from ena for performance reasons: preserving the data required for connected component traversal introduced an overhead that was unnecessary in the large majority of cases. (d0a8975)
This PR reintroduces this as an optional feature through a type parameter on the
UnificationStore.Because no extra data is stored when not using
ConnectedComponentTraversal, this feature has no impact on performance when not used.Benchmarks:
master:
this branch:
Compared to a feature, this design enables the library to be used simultaneously in both cases (connected component traversal required and not required), while benefiting from optimal performance in both cases.