Make /crate/:crate/latest/builds.json not strip .json suffix #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Jan 22, 2021
|
@syphar the "I'm feeling lucky" test has been failing intermittently, do you have time to fix it? I think the issue is we have a much lower percentage of crates with over 100 stars in the test database, you could make it configurable by moving 500 into a query parameter and passing in a different number in tests. |
jyn514
added
A-backend
|
@jyn514 I have time and can figure something out. |
|
(will do a separate PR) |
Co-authored-by: Joshua Nelson <[email protected]>
|
Can you add a test for the new behavior? You can see examples at the bottom of src/web/mod.rs |
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170 .