Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address some clippy warnings #5121

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Address some clippy warnings #5121

merged 2 commits into from
Aug 25, 2022

Conversation

jtgeibel
Copy link
Member

The 2nd commit address a warning from the beta channel, and the 1st commit is from nightly. Both cleanups are reasonable.

Turbo87
Turbo87 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the failing Percy CI job is an issue on their side. seems highly unlikely that changing the Rust code would cause any visual changes on the frontend test suite 😅

@Turbo87 Turbo87 merged commit 3d71217 into master Aug 25, 2022
@Turbo87 Turbo87 deleted the clippy-fixups branch August 25, 2022 06:45
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

@arlosi arlosi arlosi approved these changes

Assignees
No one assigned
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtgeibel @Turbo87 @arlosi