-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ember-source from 3.16.1 to 3.16.3 #2221
Bump ember-source from 3.16.1 to 3.16.3 #2221
Conversation
r? @sgrif (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit ae1164f has been approved by |
a8bfd96
to
34868f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR also breaks the "New Token" button, like the previous bump to 3.16.2 did. There is some additional information in #2211 where the change was reverted. It seems to be an incompatibility with another dependency bump introduced recently (because the original PR #2201 works fine and only failed after merging with a few other changes on master).
r? @locks |
☔ The latest upstream changes (presumably #2218) made this pull request unmergeable. Please resolve the merge conflicts. |
34868f5
to
7cec2ad
Compare
Hhhmm, interesting 🤔 Sorry for missing the problem, I'll make sure to test the new token flow next time. |
☔ The latest upstream changes (presumably #2239) made this pull request unmergeable. Please resolve the merge conflicts. |
Bumps [ember-source](https://github.com/emberjs/ember.js) from 3.16.1 to 3.16.3. - [Release notes](https://github.com/emberjs/ember.js/releases) - [Changelog](https://github.com/emberjs/ember.js/blob/v3.16.3/CHANGELOG.md) - [Commits](emberjs/ember.js@v3.16.1...v3.16.3) Signed-off-by: dependabot-preview[bot] <[email protected]>
7cec2ad
to
ec388a4
Compare
@dependabot rebase |
Superseded by #2254. |
Bumps ember-source from 3.16.1 to 3.16.3.
Release notes
Sourced from ember-source's releases.
Changelog
Sourced from ember-source's changelog.
Commits
7a78633
v3.16.32cfb760
Add v3.16.3 to CHANGELOG5ca7772
[DOC release] Update documentation for tracked with classic classes1b53ac0
[BUGFIX lts] Add test ensuring singletons instantiated during destruction are...97c3993
[BUGFIX lts] Workaround for integer literals55ffe41
Revert "[BUGFIX lts] Workaround for integer literals"9ec1702
[BUGFIX lts] Workaround for integer literalse295527
3.16.283410de
Add v3.16.2 to CHANGELOG.md.055fab0
[BUGFIX lts] Revert container deprecationDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.yml
file in this repo: