Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ember-source from 3.16.1 to 3.16.3 #2221

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Feb 24, 2020

Bumps ember-source from 3.16.1 to 3.16.3.

Release notes

Sourced from ember-source's releases.

v3.16.2

CHANGELOG

  • #18721 [BUGFIX] Backport autotracking bugfixes
  • #18729 [BUGFIX] Remove deprecation for instantiation of new singleton instances (e.g. a service) during teardown (originally added in 3.16.1 by #18717).
Changelog

Sourced from ember-source's changelog.

v3.16.3 (February 18, 2020)

  • #18730 Workaround for the Glimmer VM bug which encodes/decodes integer literals correctly.

v3.16.2 (February 10, 2020)

  • #18721 [BUGFIX release] Backport autotracking bugfixes
  • #18729 [BUGFIX] Remove deprecation for instantiation of new singleton instances (e.g. a service) during teardown (originally added in 3.16.1 by #18717).
Commits
  • 7a78633 v3.16.3
  • 2cfb760 Add v3.16.3 to CHANGELOG
  • 5ca7772 [DOC release] Update documentation for tracked with classic classes
  • 1b53ac0 [BUGFIX lts] Add test ensuring singletons instantiated during destruction are...
  • 97c3993 [BUGFIX lts] Workaround for integer literals
  • 55ffe41 Revert "[BUGFIX lts] Workaround for integer literals"
  • 9ec1702 [BUGFIX lts] Workaround for integer literals
  • e295527 3.16.2
  • 83410de Add v3.16.2 to CHANGELOG.md.
  • 055fab0 [BUGFIX lts] Revert container deprecation
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@rust-highfive
Copy link

r? @sgrif

(rust_highfive has picked a reviewer for you, use r? to override)

@locks
Copy link
Contributor

locks commented Feb 24, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Feb 24, 2020

📌 Commit ae1164f has been approved by locks

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-source-3.16.3 branch 2 times, most recently from a8bfd96 to 34868f5 Compare February 24, 2020 18:16
Copy link
Member

@jtgeibel jtgeibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also breaks the "New Token" button, like the previous bump to 3.16.2 did. There is some additional information in #2211 where the change was reverted. It seems to be an incompatibility with another dependency bump introduced recently (because the original PR #2201 works fine and only failed after merging with a few other changes on master).

@jtgeibel
Copy link
Member

r? @locks

@rust-highfive rust-highfive assigned locks and unassigned sgrif Feb 24, 2020
@bors
Copy link
Contributor

bors commented Feb 25, 2020

☔ The latest upstream changes (presumably #2218) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-source-3.16.3 branch from 34868f5 to 7cec2ad Compare February 25, 2020 00:24
@locks
Copy link
Contributor

locks commented Feb 25, 2020

Hhhmm, interesting 🤔 Sorry for missing the problem, I'll make sure to test the new token flow next time.

@bors
Copy link
Contributor

bors commented Mar 3, 2020

☔ The latest upstream changes (presumably #2239) made this pull request unmergeable. Please resolve the merge conflicts.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/ember-source-3.16.3 branch from 7cec2ad to ec388a4 Compare March 3, 2020 15:08
@Turbo87
Copy link
Member

Turbo87 commented Mar 6, 2020

@dependabot rebase

@dependabot-preview
Copy link
Contributor Author

Superseded by #2254.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/ember-source-3.16.3 branch March 6, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants