Move 3 backend routes to /api/private/session
#1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #1920) made this pull request unmergeable. Please resolve the merge conflicts. |
jtgeibel
force-pushed
the
private-backend-session-routes
branch
from
c0dc37e to
3f66401
Compare
carols10cents
approved these changes
Dec 2, 2019
|
@bors r+ I can log in and out locally and the code looks good, I'll definitely be deploying to staging and testing there before deploying to prod :) |
|
📌 Commit 3f66401 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 2, 2019
…ls10cents Move 3 backend routes to `/api/private/session` This PR moves 3 remaining backend routes so that all backend routes are now scoped under `/api/`. Upon further examination, I've determined that the initial OAuth callback is handled by the `/authorize/github` frontend route, which has not moved. Therefore, this PR does not need to be synchronized with any changes to the GitHub OAuth settings!
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves 3 remaining backend routes so that all backend routes are now scoped under
/api/. Upon further examination, I've determined that the initial OAuth callback is handled by the/authorize/githubfrontend route, which has not moved. Therefore, this PR does not need to be synchronized with any changes to the GitHub OAuth settings!