Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display loading message while dependencies are loading #1837

Merged
merged 2 commits into from
Oct 3, 2019
Merged

Conversation

locks
Copy link
Contributor

@locks locks commented Sep 12, 2019

Fixes #554.

@rust-highfive
Copy link

r? @carols10cents

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works great!! Thank you!!

@carols10cents
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 3, 2019

📌 Commit 6127cd1 has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Oct 3, 2019

⌛ Testing commit 6127cd1 with merge e48470f...

bors added a commit that referenced this pull request Oct 3, 2019
Display loading message while dependencies are loading

Fixes #554.
@bors
Copy link
Contributor

bors commented Oct 3, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing e48470f to master...

@bors bors merged commit 6127cd1 into master Oct 3, 2019
@jtgeibel jtgeibel deleted the fix-554 branch December 12, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Dependencies: none" is displayed while dependency list is loading
5 participants