routes/crate: Fetch crate when peeked crate lacks included values #10666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
force-pushed
the
fix-missing-keywords
branch
from
2330c30 to
0b512ce
Compare
eth3lbert
commented
Feb 23, 2025
Comment on lines
+249
to
+257
| test('keywords are shown when navigating from search', async ({ page, msw }) => { | ||
| loadFixtures(msw.db); | ||
|
|
||
| await page.goto('/search?q=nanomsg'); | ||
| await page.getByRole('link', { name: 'nanomsg', exact: true }).click(); | ||
|
|
||
| await expect(page).toHaveURL('/crates/nanomsg'); | ||
| await expect(page.locator('[data-test-keyword]')).toBeVisible(); | ||
| }); |
There was a problem hiding this comment.
There's another case that would cause the same issue: navigating from dependencies that have more than one dependency (as this will query with ?ids=). We would need to expand the fixtures to have at least two dependencies. Let me know if we'd like to include this as well.
There was a problem hiding this comment.
probably fine as-is. if anything, IMHO we shouldn't extend the hardcoded fixtures and instead setup a dedicated scenario for the test. I would prefer to get rid of the fixtures in general.
|
I re-ran the failed tests, and those failures seem unrelated to this PR. |
Turbo87
approved these changes
Feb 24, 2025
Turbo87
force-pushed
the
fix-missing-keywords
branch
from
0b512ce to
98ae017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10663 .