Expose has_lib and bin_names version fields on the API

rust-lang · Jul 3, 2024 · 3dcd216 · 3dcd216
1 parent 4d80592
commit 3dcd216
Show file tree

Hide file tree

Showing 12 changed files with 41 additions and 1 deletion.
diff --git a/src/tests/krate/publish/snapshots/all__krate__publish__manifest__boolean_readme-2.snap b/src/tests/krate/publish/snapshots/all__krate__publish__manifest__boolean_readme-2.snap
@@ -1,6 +1,6 @@
 ---
 source: src/tests/krate/publish/manifest.rs
-expression: response.into_json()
+expression: response.json()
 ---
 {
   "version": {
@@ -17,13 +17,15 @@ expression: response.into_json()
         }
       }
     ],
+    "bin_names": [],
     "checksum": "418c24c55cbcde274a5b1815d2c844203c7116e7f712008f4727d38bc7c82d8d",
     "crate": "foo",
     "crate_size": 170,
     "created_at": "[datetime]",
     "dl_path": "/api/v1/crates/foo/1.0.0/download",
     "downloads": 0,
     "features": {},
+    "has_lib": false,
     "id": "[id]",
     "license": "MIT",
     "links": {

diff --git a/src/tests/routes/crates/snapshots/all__routes__crates__read__show.snap b/src/tests/routes/crates/snapshots/all__routes__crates__read__show.snap
@@ -49,13 +49,15 @@ expression: response.json()
   "versions": [
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "foo_show",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/foo_show/1.0.0/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 1,
       "license": null,
       "links": {
@@ -72,13 +74,15 @@ expression: response.json()
     },
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "foo_show",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/foo_show/0.5.1/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 3,
       "license": null,
       "links": {
@@ -101,13 +105,15 @@ expression: response.json()
     },
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "foo_show",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/foo_show/0.5.0/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 2,
       "license": null,
       "links": {

diff --git a/...ates__reverse_dependencies__prerelease_versions_not_included_in_reverse_dependencies.snap b/...ates__reverse_dependencies__prerelease_versions_not_included_in_reverse_dependencies.snap
@@ -23,13 +23,15 @@ expression: response.json()
   "versions": [
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "c3",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/c3/1.0.0/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 3,
       "license": null,
       "links": {

diff --git a/...tes/crates/snapshots/all__routes__crates__reverse_dependencies__reverse_dependencies.snap b/...tes/crates/snapshots/all__routes__crates__reverse_dependencies__reverse_dependencies.snap
@@ -23,13 +23,15 @@ expression: response.json()
   "versions": [
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "c2",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/c2/1.1.0/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 3,
       "license": null,
       "links": {

diff --git a/...__reverse_dependencies__reverse_dependencies_includes_published_by_user_when_present.snap b/...__reverse_dependencies__reverse_dependencies_includes_published_by_user_when_present.snap
@@ -35,13 +35,15 @@ expression: response.json()
   "versions": [
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "c3",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/c3/3.0.0/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 3,
       "license": null,
       "links": {
@@ -64,13 +66,15 @@ expression: response.json()
     },
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "c2",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/c2/2.0.0/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 2,
       "license": null,
       "links": {

diff --git a/...__reverse_dependencies__reverse_dependencies_query_supports_u64_version_number_parts.snap b/...__reverse_dependencies__reverse_dependencies_query_supports_u64_version_number_parts.snap
@@ -23,13 +23,15 @@ expression: response.json()
   "versions": [
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "c2",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/c2/1.0.18446744073709551615/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 2,
       "license": null,
       "links": {

diff --git a/...verse_dependencies__reverse_dependencies_when_old_version_doesnt_depend_but_new_does.snap b/...verse_dependencies__reverse_dependencies_when_old_version_doesnt_depend_but_new_does.snap
@@ -23,13 +23,15 @@ expression: response.json()
   "versions": [
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "c2",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/c2/2.0.0/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 3,
       "license": null,
       "links": {

diff --git a/...__crates__reverse_dependencies__yanked_versions_not_included_in_reverse_dependencies.snap b/...__crates__reverse_dependencies__yanked_versions_not_included_in_reverse_dependencies.snap
@@ -23,13 +23,15 @@ expression: response.json()
   "versions": [
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "c2",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/c2/2.0.0/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 3,
       "license": null,
       "links": {

diff --git a/...tests/routes/crates/versions/snapshots/all__routes__crates__versions__list__versions.snap b/...tests/routes/crates/versions/snapshots/all__routes__crates__versions__list__versions.snap
@@ -6,13 +6,15 @@ expression: response.json()
   "versions": [
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "foo_versions",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/foo_versions/1.0.0/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 2,
       "license": null,
       "links": {
@@ -29,13 +31,15 @@ expression: response.json()
     },
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "foo_versions",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/foo_versions/0.5.1/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 1,
       "license": null,
       "links": {
@@ -58,13 +62,15 @@ expression: response.json()
     },
     {
       "audit_actions": [],
+      "bin_names": null,
       "checksum": "                                                                ",
       "crate": "foo_versions",
       "crate_size": 0,
       "created_at": "[datetime]",
       "dl_path": "/api/v1/crates/foo_versions/0.5.0/download",
       "downloads": 0,
       "features": {},
+      "has_lib": null,
       "id": 3,
       "license": null,
       "links": {

diff --git a/...s/all__routes__crates__versions__read__show_by_crate_name_and_semver_no_published_by.snap b/...s/all__routes__crates__versions__read__show_by_crate_name_and_semver_no_published_by.snap
@@ -5,13 +5,15 @@ expression: json
 {
   "version": {
     "audit_actions": [],
+    "bin_names": null,
     "checksum": "                                                                ",
     "crate": "foo_vers_show_no_pb",
     "crate_size": 0,
     "created_at": "[datetime]",
     "dl_path": "/api/v1/crates/foo_vers_show_no_pb/1.0.0/download",
     "downloads": 0,
     "features": {},
+    "has_lib": null,
     "id": "[id]",
     "license": null,
     "links": {

diff --git a/...rsions/snapshots/all__routes__crates__versions__read__show_by_crate_name_and_version.snap b/...rsions/snapshots/all__routes__crates__versions__read__show_by_crate_name_and_version.snap
@@ -5,13 +5,15 @@ expression: json
 {
   "version": {
     "audit_actions": [],
+    "bin_names": null,
     "checksum": "c241cd77c3723ccf1aa453f169ee60c0a888344da504bee0142adb859092acb4",
     "crate": "foo_vers_show",
     "crate_size": 1234,
     "created_at": "[datetime]",
     "dl_path": "/api/v1/crates/foo_vers_show/2.0.0/download",
     "downloads": 0,
     "features": {},
+    "has_lib": null,
     "id": "[id]",
     "license": null,
     "links": {

diff --git a/src/views.rs b/src/views.rs
@@ -566,6 +566,8 @@ pub struct EncodableVersion {
     pub audit_actions: Vec<EncodableAuditAction>,
     pub checksum: String,
     pub rust_version: Option<String>,
+    pub has_lib: Option<bool>,
+    pub bin_names: Option<Vec<Option<String>>>,
 }
 
 impl EncodableVersion {
@@ -587,6 +589,8 @@ impl EncodableVersion {
             crate_size,
             checksum,
             rust_version,
+            has_lib,
+            bin_names,
             ..
         } = version;
 
@@ -612,6 +616,8 @@ impl EncodableVersion {
             crate_size,
             checksum,
             rust_version,
+            has_lib,
+            bin_names,
             published_by: published_by.map(User::into),
             audit_actions: audit_actions
                 .into_iter()
@@ -736,6 +742,8 @@ mod tests {
             crate_size: Some(1234),
             checksum: String::new(),
             rust_version: None,
+            has_lib: None,
+            bin_names: None,
             published_by: None,
             audit_actions: vec![EncodableAuditAction {
                 action: "publish".to_string(),